Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add study for Rewards 3.0 UI and enable in Beta and Nightly #1292

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Add study for Rewards 3.0 UI and enable in Beta and Nightly #1292

merged 1 commit into from
Jan 14, 2025

Conversation

zenparsing
Copy link
Contributor

Add study for Rewards 3.0 UI (feature name "BraveRewardsNewRewardsUI") and enable in Beta and Nightly.

@zenparsing zenparsing requested a review from a team as a code owner January 8, 2025 15:31
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025 •
edited
Loading

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1292.
    Android: Set the command line to --variations-pr=1292 in debug menu, restart the browser.
    iOS: Set Variations PR to 1292 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

Parameter Value
Version pull/1292@25d19f6f4717ebaf6ac37e1ce9167e36f7ff89fe
Uploaded Wed, 08 Jan 2025 15:32:18 GMT
PR commit 72308a9
Base commit a57acce
Merge commit 25d19f6
Serial number acc973bc4ceb764cf567218018462743

@kjozwiak
Copy link
Member

kjozwiak commented Jan 14, 2025 •
edited
Loading

Windows x64 verification(s):

Nightly - BraveRewardsNewRewardsUIStudy:Enabled

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.76.11 Chromium: 132.0.6834.83 (Official Build) nightly (64-bit)
-- | --
Revision | d9d5ac769a005636b8f89eeb153279dec5169f7c
OS | Windows 11 Version 24H2 (Build 26100.2605)
  • launched/re-launched 1.76.11 Chromium: 132.0.6834.83 using brave.exe --enable-logging=stderr --variations-pr=1292
  • ensured that pull/1292@25d19f6f4717ebaf6ac37e1ce9167e36f7ff89fe via brave://version under Active variations
  • ensured that BraveRewardsNewRewardsUIStudy:Enabled via brave://version
  • ensured that the new Rewards 3.0 panel is being used when clicking on the BAT icon
  • ensured that the new UI/Design is being used/visible via brave://rewards
Example Example Example Example
enabled1 enabled2 enabled3 enabled4

BETA - BraveRewardsNewRewardsUIStudy:Enabled

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.75.159 Chromium: 132.0.6834.83 (Official Build) beta (64-bit)
-- | --
Revision | a7b6f5093a2dad31fc3f56241a7d55be255e69e2
OS | Windows 11 Version 24H2 (Build 26100.2605)
  • launched/re-launched 1.75.159 Chromium: 132.0.6834.83 using brave.exe --enable-logging=stderr --variations-pr=1292
  • ensured that pull/1292@25d19f6f4717ebaf6ac37e1ce9167e36f7ff89fe via brave://version under Active variations
  • ensured that BraveRewardsNewRewardsUIStudy:Enabled via brave://version
  • ensured that the new Rewards 3.0 panel is being used when clicking on the BAT icon
  • ensured that the new UI/Design is being used/visible via brave://rewards
Example Example Example Example
image image image image

Release - BraveRewardsNewRewardsUIStudy (not being used/visible)

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.73.105 Chromium: 131.0.6778.265 (Official Build) (64-bit)
-- | --
Revision | adf1b0089a62f3ed9260e23c8cd3c7862a1e410c
OS | Windows 11 Version 24H2 (Build 26100.2605)
  • launched/re-launched 1.73.105 Chromium: 131.0.6778.265 using brave.exe --enable-logging=stderr --variations-pr=1292
  • ensured that pull/1292@25d19f6f4717ebaf6ac37e1ce9167e36f7ff89fe via brave://version under Active variations
  • ensured that BraveRewardsNewRewardsUIStudy is not being used/displayed via brave://version
  • ensured that the current Brave Rewards UI is being used via the rewards panel and brave://rewards
Example Example Example Example
image image image image

kjozwiak
kjozwiak approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into main/production approved after deliberating with @brave/uplift-approvers. QA has verified the Griffin study on Win via Nightly, BETA & Release as per #1292 (comment).

@kjozwiak kjozwiak added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit e137f03 Jan 14, 2025
6 checks passed
@kjozwiak kjozwiak deleted the ksmith-rewards-3-beta branch January 14, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zenparsing @kjozwiak